Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: clisqlshell: correctly handle sending zero input for COPY #93261

Merged
merged 1 commit into from
Dec 9, 2022
Merged

release-22.2: clisqlshell: correctly handle sending zero input for COPY #93261

merged 1 commit into from
Dec 9, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 8, 2022 •
edited by rafiss
Loading

Backport 1/1 commits from #93100 on behalf of @otan.

/cc @cockroachdb/release

Resolves #93051

Release note (bug fix): Previously, empty COPY commands would not escape after an EOF character or error if encountering a \. with no input. This is now resolved.

Release justification: low risk bug fix

@otan
clisqlshell: correctly handle sending zero input for COPY
5d12198 
Release note (bug fix): Previously, empty COPY commands would not escape
after an EOF character or error if encountering a `\.` with no input.
This is now resolved.
@blathers-crl blathers-crl bot requested a review from a team December 8, 2022 15:04
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 8, 2022 15:04
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-93100 branch from 056ed68 to 5d12198 Compare December 8, 2022 15:04
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 8, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from rafiss December 8, 2022 15:04
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 8, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit 45cceae into release-22.2 Dec 9, 2022
@rafiss rafiss deleted the blathers/backport-release-22.2-93100 branch December 9, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees

@otan otan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @otan